What is the intended usage of GetParams in CRDs?

[wlynch]

Brought up in #895 (comment)

In all Tekton CRDs, there is a func that looks like:

func (s Resource) GetParams() []Param { return []Param{} }

https://github.com/tektoncd/pipeline/search?q=GetParams&type=Code

It looks like it is defined to satisfy the PipelineResourceInterface, but I can't find a place where this used meaningfully. What is the intended purpose of this func? Should we be populating this func with values for Tekton CRDs, or should we remove it?

/cc @bobcatfish @vdemeester

[bobcatfish]

The work to do here would be to do a bit of digging through the history of the GetParams function and see:

• If it is actually doing something useful right now that we're not seeing
• If we can make an informed guess about what the original purpose was and if that makes sense

[dlorenc]

Yeah, looks like this is useless. Removing now.

[vincent-pli]

Maybe it's useful when we decide to implement Variable substitution of PipelineResource, I guess...

[bobcatfish]

Since this was removed I'm going to close this issue!