Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds container name to taskrun.status.steps #1100

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Adds container name to taskrun.status.steps #1100

merged 1 commit into from
Jul 25, 2019

Conversation

hrishin
Copy link
Member

@hrishin hrishin commented Jul 18, 2019

Changes

Recently while introducing some minor changes in steps status details, it broked some
functionality across CLI, Dashboard and other projects integration.
Maybe because those integration tries to extract some attributes related to the pod base on
TaskRun.Status fields i.e extracting the container name from step's name for
fetching the logs for TaskRun.Status.Steps.

In order to fix the issue, this patch adds container name in step's status. So that
consumer of status API dont need figure internal details based on steps details.

Fixes #1027

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Release Notes

Now `container name` is available in `TaskRun.Status.Steps.Container` field

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jul 18, 2019
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2019
@bobcatfish
Copy link
Collaborator

Thanks for this! Seems reasonable to me! I'd like to get a review by another OWNER before we merge ( @abayer @dlorenc @vdemeester @imjasonh )

afrittoli
afrittoli reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you. I agree that using ContainerName would be nicer.

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2019
vdemeester
vdemeester approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrishin can you squash your commit ? 👼 🤗
/meow boxes

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

@hrishin can you squash your commit ? 👼 🤗
/meow boxes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@hrishin
Adds container name to taskrun.status.steps
34b8084 
Recently while introducing some minor changes in steps status details, it broked some
functionality across CLI, Dashboard and other projects integration.
Maybe because those integration tries to extract some attributes related to the pod base on
TaskRun.Status fields i.e extracting the container name from step's name for
fetching the logs for TaskRun.Status.Steps.

In order to fix the issue, thi patch adds container name in step's status. So that
consumer of status api dont need figure internal details bsed on steps details.

Fixes tektoncd#1027
@hrishin
Copy link
Member Author

hrishin commented Jul 25, 2019

Done @vdemeester 👍

Thank you!! all for the reviews.

vdemeester
vdemeester approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrishin, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit c2ee772 into tektoncd:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abayer abayer abayer left review comments

@imjasonh imjasonh imjasonh left review comments

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: extend taskrun.status.steps to have container name
8 participants
@hrishin @bobcatfish @tekton-robot @vdemeester @abayer @imjasonh @afrittoli @googlebot