Propagate labels and annotation early on for PipelineRun #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
|
/hold |
tekton-robot
added
the
do-not-merge/hold
If a PipelineRun fails on validation, with `ReasonInvalidGraph`, `ReasonInvalidBindings` or `ReasonParameterTypeMismatch`, the PipelineRun do not inherit the referenced Pipeline labels and annotation. This poses a problem for tools that uses those labels, especially `tekton.dev/pipeline=` to filter the PipelineRun for a given Pipeline. This commits fixes that by propagating those labels and annotation as early as it can (aka after making sure the PipelineRef is valid) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
1160-labels-early
branch
from
314abce
to
b51ce96
Compare
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
@bobcatfish @dibyom tentatively adding it to 0.6.0 milestone 👼 |
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If a PipelineRun fails on validation, with
ReasonInvalidGraph,ReasonInvalidBindingsorReasonParameterTypeMismatch, thePipelineRun do not inherit the referenced Pipeline labels and
annotation.
This poses a problem for tools that uses those labels, especially
tekton.dev/pipeline=to filter the PipelineRun for a givenPipeline.
This commits fixes that by propagating those labels and annotation as
early as it can (aka after making sure the PipelineRef is valid)
Fixes #1160
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task and TaskRun to build and release this image
Release Notes