Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for release-postprocessing #1457

Merged
merged 1 commit into from
Oct 27, 2019

Conversation

afrittoli
Copy link
Member

Add a cloud event pipeline resource to the publish-tekton-pipelines
Task. This can be used to trigger post-processing services like
log collection and automatic post release testing.

Add a resource to the pipeline-release and to the
pipeline-release-nightly-triggers pipelines to match the Task one.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Oct 23, 2019
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 23, 2019
@afrittoli afrittoli force-pushed the release_postprocessing branch 2 times, most recently from b1be433 to 115892c Compare October 23, 2019 13:12
tekton/README.md Outdated Show resolved Hide resolved
tekton/README.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 24, 2019

Some minor nits but otherwise
/lgtm

@tekton-robot tekton-robot assigned ghost Oct 24, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
Add a cloud event pipeline resource to the publish-tekton-pipelines
Task. This can be used to trigger post-processing services like
log collection and automatic post release testing.

Add a resource to the pipeline-release and to the
pipeline-release-nightly-triggers pipelines to match the Task one.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@afrittoli
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit fa1704d into tektoncd:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants