Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable colour in tkn logs #1525

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

afrittoli
Copy link
Member

We use tkn to capture task and pipeline logs from CI runs. By default
the output includes colour, but in a log file the colour codes
make the log less readable, e.g.

I1104 14:45:18.925] [92m[92;1m[client] [0m7ddbc47eeb70: Pulling fs layer

Add the --nocolour flag to avoid that.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

We use tkn to capture task and pipeline logs from CI runs. By default
the output includes colour, but in a log file the colour codes
make the log less readable, e.g.

I1104 14:45:18.925] [92m[92;1m[client] [0m7ddbc47eeb70: Pulling fs layer

Add the --nocolour flag to avoid that.
@tekton-robot tekton-robot requested review from imjasonh and a user November 5, 2019 10:04
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 5, 2019
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@tekton-robot tekton-robot merged commit 199ffdd into tektoncd:master Nov 5, 2019
@afrittoli
Copy link
Member Author

I wonder why no CI test was executed here? This does not look right.

@vdemeester
Copy link
Member

@afrittoli integration did run, the build/unit tests did not as you didn't change any go code or files that are related to those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants