Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: group vars 👼 #1528

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

vdemeester
Copy link
Member

Changes

👼 🙏

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 6, 2019
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2019
@ghost
Copy link

ghost commented Nov 6, 2019

/lgtm

@tekton-robot tekton-robot assigned ghost Nov 6, 2019
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@ghost
Copy link

ghost commented Nov 6, 2019

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@vdemeester
Copy link
Member Author

Oups.. got gofmted...

I1106 14:40:06.250] -------------------------------------------
I1106 14:40:06.250] ---- Checking go code style with gofmt ----
I1106 14:40:06.251] -------------------------------------------
I1106 14:40:07.550] diff -u pkg/apis/pipeline/v1alpha1/resource_types.go.orig pkg/apis/pipeline/v1alpha1/resource_types.go
I1106 14:40:07.550] --- pkg/apis/pipeline/v1alpha1/resource_types.go.orig	2019-11-06 14:40:07.194055109 +0000
I1106 14:40:07.550] +++ pkg/apis/pipeline/v1alpha1/resource_types.go	2019-11-06 14:40:07.194055109 +0000
I1106 14:40:07.550] @@ -59,7 +59,6 @@
I1106 14:40:07.551]  	_ apis.Defaultable = (*PipelineResource)(nil)
I1106 14:40:07.551]  )
I1106 14:40:07.551]  
I1106 14:40:07.551] -
I1106 14:40:07.551]  // PipelineResourceInterface interface to be implemented by different PipelineResource types
I1106 14:40:07.551]  type PipelineResourceInterface interface {
I1106 14:40:07.552]  	// GetName returns the name of this PipelineResource instance.
I1106 14:40:07.552] diff -u pkg/apis/pipeline/v1alpha1/pipelinerun_types.go.orig pkg/apis/pipeline/v1alpha1/pipelinerun_types.go
I1106 14:40:07.552] --- pkg/apis/pipeline/v1alpha1/pipelinerun_types.go.orig	2019-11-06 14:40:07.277062764 +0000
I1106 14:40:07.552] +++ pkg/apis/pipeline/v1alpha1/pipelinerun_types.go	2019-11-06 14:40:07.277062764 +0000
I1106 14:40:07.552] @@ -42,7 +42,6 @@
I1106 14:40:07.552]  	_ apis.Defaultable = (*PipelineRun)(nil)
I1106 14:40:07.553]  )
I1106 14:40:07.553]  
I1106 14:40:07.553] -
I1106 14:40:07.553]  // PipelineRunSpec defines the desired state of PipelineRun
I1106 14:40:07.553]  type PipelineRunSpec struct {
I1106 14:40:07.553]  	// +optional
I1106 14:40:07.554] diff -u pkg/apis/pipeline/v1alpha1/taskrun_types.go.orig pkg/apis/pipeline/v1alpha1/taskrun_types.go
I1106 14:40:07.554] --- pkg/apis/pipeline/v1alpha1/taskrun_types.go.orig	2019-11-06 14:40:07.296064517 +0000
I1106 14:40:07.554] +++ pkg/apis/pipeline/v1alpha1/taskrun_types.go	2019-11-06 14:40:07.298064701 +0000
I1106 14:40:07.554] @@ -33,7 +33,6 @@
I1106 14:40:07.554]  	_ apis.Defaultable = (*TaskRun)(nil)
I1106 14:40:07.554]  )
I1106 14:40:07.554]  
I1106 14:40:07.555] -
I1106 14:40:07.555]  // TaskRunSpec defines the desired state of TaskRun
I1106 14:40:07.555]  type TaskRunSpec struct {
I1106 14:40:07.555]  	// +optional
I1106 14:40:08.283] ------------------------------------

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@abayer
Copy link
Contributor

abayer commented Nov 6, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@tekton-robot tekton-robot merged commit 5a22142 into tektoncd:master Nov 6, 2019
@vdemeester vdemeester deleted the types-vars branch November 6, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants