Move Validatable/Defaultable interface checks out #1571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These type checks are a signal that the types are validatable/defaultable, which is nice, but having them in the _types.go files makes it more difficult to consume those files by themselves.
There are no functiona changes expected.
As an alternative we could move these type checks into _test.go files, where consumers who only need the message types could just not consume the _test.go files. Or we could just remove the type checks entirely -- these types are still enforced when building
cmd/controller
andcmd/webhook
.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.