Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Validatable/Defaultable interface checks out #1571

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

imjasonh
Copy link
Member

These type checks are a signal that the types are validatable/defaultable, which is nice, but having them in the _types.go files makes it more difficult to consume those files by themselves.

There are no functiona changes expected.

As an alternative we could move these type checks into _test.go files, where consumers who only need the message types could just not consume the _test.go files. Or we could just remove the type checks entirely -- these types are still enforced when building cmd/controller and cmd/webhook.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

These type checks are a signal that the types are
validatable/defaultable, which is nice, but having them in the _types.go
files makes it more difficult to consume those files by themselves.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 14, 2019
@tekton-robot tekton-robot requested review from dlorenc and a user November 14, 2019 20:04
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Nov 14, 2019

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Nov 14, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@tekton-robot tekton-robot merged commit 6bb6361 into tektoncd:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants