Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Kubernetes 1.13.4 libraries #1572

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

imjasonh
Copy link
Member

What I did

  1. Updated Gopkg.lock to pin to kubernetes 1.13.4
  2. dep ensure
  3. ./hack/update-codegen.sh
  4. go build ./...
  5. go test ./...
  6. Send PR (you are here)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Depends on Kubernetes 1.13.4 libraries

/assign vdemeester

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Nov 14, 2019
@tekton-robot tekton-robot requested review from abayer and a user November 14, 2019 21:14
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2019
@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@imjasonh imjasonh changed the title Update to Kubernetest 1.13.4 libraries Update to Kubernetes 1.13.4 libraries Nov 14, 2019
@imjasonh
Copy link
Member Author

Oh rad it looks like this also lets us drop -alsologtostderr from our controller flags! 🎉

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@tekton-robot tekton-robot merged commit 75e47ca into tektoncd:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants