Add empty v1alpha2 package 🎐 #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
vdemeester
force-pushed
the
into-v1alpha2
branch
from
1c4798f
to
d5ea27f
Compare
tekton-robot
added
size/M
This adds an empty v1alpha2 package, which serve as the base to port v1alpha1 types to v1alpha2 while still being able to work on v1alpha1 *and* do the appropriate refactoring while doing this. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
into-v1alpha2
branch
from
d5ea27f
to
ef6d85c
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds an empty v1alpha2 package, which serve as the base to port
v1alpha1 types to v1alpha2 while still being able to work on
v1alpha1 and do the appropriate refactoring while doing this.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
This is the smallest change from #1529 I could came up with to "bootstrap" my work without having to go through rebase and refactoring hell in one go 😅
The package name doesn't really matter and could be renamed
v1beta1later on. It is not exposed/published or even taken into account by anything (webhook, controller, …), except that client are generated. Which leads to a question : should we have the clients generated now or in the "latest" piece of dev on this ?This should allow us working on this quickly without fear of breaking people and without having to get it in for 0.9.0 👼
/cc @bobcatfish @skaegi @dlorenc @imjasonh
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.