Allow disabling implicit HOME overwrite #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
tekton-robot
added
size/L
ghost
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
ghost
changed the title
|
okey dokey, I think this PR is ready for review now. |
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
Feb 24, 2020
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vdemeester
added
the
needs-rebase
Tekton currently overwrites a Task container's HOME environment variable so that it always points to /tekton/home. This behaviour causes issues for any image that expects this variable to be set to some predefined value. This PR introduces a feature flag configmap and a flag to disable Tekton's HOME behaviour. The default behaviour remains the same but in an upcoming release we will change this default so that Tekton no longer overwrites the HOME variable.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tekton currently overwrites the $HOME variables in task containers. This behaviour is problematic when an image explicitly sets the HOME env var and expects it to be set to that value upon running.
This PR introduces a
feature-flagsConfigMap with a single flag -disable-home-env-overwrite- that, when set to "true" will prevent Tekton from overriding the $HOME variable in Task containers. This behaviour will be kept for one release which must include a deprecation warning that the behaviour will be changing soon. In the release after that the flag will be flipped so that the default behaviour becomes for Tekton to NOT override the $HOME variable.Contributes to issues #2013 and #1836
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes