Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "commented" website front matter to docs #2283

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Adds "commented" website front matter to docs #2283

merged 1 commit into from
Mar 25, 2020

Conversation

skaegi
Copy link
Contributor

@skaegi skaegi commented Mar 25, 2020

This change adds the front matter needed for the website without altering the site markdown or adding titles. It does this by adding the front matter in comment tags.

The tutorial and install are not part of the website currently so links to them under docs/ use absolute urls to allow them to work in both the website and in the pipeline repo

Changes

update /docs markdown files with front matter

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

This change adds the front matter needed for the website without altering the site markdown or adding titles. It does this by adding the front matter in comment tags.

The tutorial and install are not part of the website currently so links to them under docs/ use absolute urls to allow them to work in both the website and in the pipeline repo
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Mar 25, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🙃
We can cherry-pick this in 0.11 even after the rc3 😝

/cc @sbwsg

@tekton-robot tekton-robot requested a review from a user March 25, 2020 07:13
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@vdemeester vdemeester added kind/documentation Categorizes issue or PR as related to documentation. needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Really glad the title blocks still get picked up even when wrapped in comments.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@ghost
Copy link

ghost commented Mar 25, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Mar 25, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@tekton-robot tekton-robot merged commit 0019473 into tektoncd:master Mar 25, 2020
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants