Sort and remove duplicate when set "taskrun.status.taskResults"

[vincent-pli]

Fix issue: #2466

1. Sort pod.containerStatuses before parse
2. Overwrite older items

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

[vincent-pli]

/test pull-tekton-pipeline-integration-tests

[vdemeester]

/cc @othomann
/kind bug

[othomann]

Looks good to me.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	75.2%	74.6%	-0.6

[vincent-pli]

/test pull-tekton-pipeline-integration-tests

[vdemeester]

/kind bug

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[vdemeester]

/cc @sbwsg @bobcatfish

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[ghost]

Thanks for this @vincent-pli could you remove the Release Notes section in the PR description if there's none to include?

[vincent-pli]

@sbwsg removed the Release Notes, thanks

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	75.2%	76.1%	0.8

[ghost]

Looks good, let me know if you want to make the final suggested change and then I'll approve / lgtm!

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	75.2%	76.1%	0.8

[jlpettersson]

/lgtm

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	75.2%	76.1%	0.8

[pritidesai]

thanks @vincent-pli
/lgtm

[pritidesai]

thanks @vincent-pli

just reiterating, task results are assigned values appearing in latest Container State i.e. task result named resultNameOne is assigned resultValueThree and not resultValueOne

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: othomann, pritidesai, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment