-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release v0.12.1 #2620
Prepare for release v0.12.1 #2620
Conversation
Deploying pipelines 0.12.0 into a cluster with pod security policy enabled will result in the webhook deployment entering a failed state. This happens because the webhook does not have the rights to use pod security policies. In prior versions of Tekton the webhook shared its clusterrole with the controller, and was granted much broader permissions. Since 0.12.0 the permissions given to the controller and webhook have been split. In splitting the permissions the controller continued to received the PSP "use" permission but the webhook did not; an oversight. This commit adds the "use" verb for pod security policies to the webhook clusterrole.
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
This PR cannot be merged: expecting exactly one kind/ label Available
|
/kind misc |
This removes some flags that are now in the configuration, and add more information. Trying `disable-all` with `enable` to limit the linter run to only the one we specify. Also trying to run less linters on `_test.go`. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
The labels `pipeline.tekton.dev/release: "devel"` and `version: "devel"` are present in more files than just `controller.yaml` and `webhook.yaml`. But we only replace those in these files. This fixes that by updating the `devel` version in any `config/` yaml files. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Cherry-pick to commits to the release-v0.12.x branch, in preparation for the release v0.12.1:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes