Revert "config: prefixes image names with ko:// scheme 📠"

[afrittoli]

Changes

This reverts commit eb56d0f.
Remove the rest of ko:// prefixes in manifests.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Remove the `ko://` prefix from images in manifests

[afrittoli]

/kind misc

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[imjasonh]

Can you explain why? Does this break something?

[afrittoli]

Can you explain why? Does this break something?

We had to revert this on master because the latest version of ko breaks when using the preserve path options like we do @bobcatfish made an issue on ko side.

Since I'm trying to do a minor release, I need to cherry-pick this or else the release fails:

2020/05/14 22:43:58 Publishing gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/controller:v0.12.1
2020/05/14 22:44:00 Published gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/controller:v0.12.1@sha256:89d73ac598d95ec51a4f5b3d5874f05448033f8f314d5b5bc703ea02be12a4f4
2020/05/14 22:44:02 error processing import paths in "/workspace/go/src/github.com/tektoncd/pipeline/config/controller.yaml": error resolving image references: repository can only contain the runes `abcdefghijklmnopqrstuvwxyz0123456789_-./`: tekton-releases/ko://github.com/tektoncd/pipeline/cmd/pullrequest-init

[imjasonh]

+1, thanks for explaining. So this is only something we need for the minor release branch, and only because it happens to use a bad version of ko. This isn't something we should recommend at head or going forward.

/lgtm
/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ImJasonH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment