Google/ko 5.0+ requires images to be prefixed by ko:// .

[akram]

Changes

Adds ko:// scheme to images used by ko

See ko-build/ko#158

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Adds ko:// scheme to images used by ko (dev only)

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Akram Ben Aissi (fad4250)

[tekton-robot]

Hi @akram. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[tekton-robot]

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

[afrittoli]

Thanks for this.

We tried this before (#2216, #2216) but we reverted it (#2561, #2624, #2624) because it broke our release process, there is an issue (ko-build/ko#164) with ko when using ko:// and the -P (preserve path) flag.

As far as I can see the issue on ko side is still open. I would prefer once the issue is solved on ko side to revert the reverts and get the ko:// back in that way.

[akram]

note @afrittoli
I will keep it up to you close the PR if it is a dup or let it open if it could be helpful in a close future.

[vdemeester]

/cc @mattmoor @bobcatfish what is the status on ko and our previous failures on using ko:// ? 🙃

[bobcatfish]

@vdemeester afaik someone needs to experiment with changing the yamls back to using ko:// and possibly bumping the pinned version of ko we are building into the gcloud images

as a bonus it would be great to understand more about how the version pinning actually works since it doesnt seem to guarantee that we get the pinned version at all

[mattmoor]

I linked what we're doing in the Knative prow images from the linked issue above.

As far as I know 0.5.1 (what we pin) fixes what you are seeing and HEAD has a further fix for "local" mode, which we've been using successfully with KinD for weeks now.

[vdemeester]

/kind misc
/ok-to-test

[vdemeester]

/kind misc
Rebased and updated the release-note part.

/lgtm

[bobcatfish]

/test pull-tekton-pipeline-integration-tests

[bobcatfish]

let's give it a shot

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

Looks like #2850 should have fixed the cancel tests, however it did get merged 4 hours ago and the latest flake was 1 hour ago so maybe we should keep an eye on it.

[vdemeester]

test TestPipelineLevelFinally_OneDAGTaskFailed_Failure 1m26s.. a new one…
/retest