Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gopkg.toml to remove spf13 git hash 👼 #286

Merged

Conversation

vdemeester
Copy link
Member

Signed-off-by: Vincent Demeester vdemeest@redhat.com

- `spf13/cobra` is not used at all (not present in the lock or in the
  vendor folder) *and* the fix spf13/cobra#662 is released too (so
  `dep` would pick up if we depend on it.
- `spf13/pflag` 1.0.3 is more recent than the toml git hash 👅

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2018
@bobcatfish
Copy link
Collaborator

Thanks for the cleanup @vdemeester ! How'd you discover it wasn't in use? Any recommendations on how we can make sure we won't leave around deps we don't need?

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2018
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@vdemeester
Copy link
Member Author

vdemeester commented Nov 30, 2018

Thanks for the cleanup @vdemeester ! How'd you discover it wasn't in use? Any recommendations on how we can make sure we won't leave around deps we don't need?

I vaguely remembered I did the same on knative/build a while ago 😅 and it's not present in the Gopkg.lock file, so it's not in use 👼 We may want to look into setting up some bot work (à-la @mattmoor @mattmoor-sockpuppet 😝), that would check those, but I don't think it's gonna happen too much in the project lifecycle.

@knative-prow-robot knative-prow-robot merged commit 7fc6a3f into tektoncd:master Nov 30, 2018
@vdemeester vdemeester deleted the dep-spf13-clean-update branch November 30, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants