Add pipeline run support for cloud events #2938
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
afrittoli
force-pushed
the
issues/2082-add-cloud-events-pipelinerun
branch
from
e51caf3
to
f1fa437
Compare
|
/kind feature |
tekton-robot
added
the
kind/feature
|
The following is the coverage report on the affected files.
|
afrittoli
force-pushed
the
issues/2082-add-cloud-events-pipelinerun
branch
from
f1fa437
to
b820c9d
Compare
|
The following is the coverage report on the affected files.
|
afrittoli
force-pushed
the
issues/2082-add-cloud-events-pipelinerun
branch
from
b820c9d
to
d7716b3
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
afrittoli
force-pushed
the
issues/2082-add-cloud-events-pipelinerun
branch
from
d7716b3
to
14bc469
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
needs-rebase
Replace the pipeline run controller own config store with the shared one used by the taskrun controller too. The pipeline run config store is only useful to the artifact storage, however the artifact storage loads the config by fetching the configmap via the kube client, so it does not use the config store. Attaching the shared config store to the controller, along with the cloud events client, enables the pipeline run controller to start sending cloud events for all events where we send k8s events today (except for error ones). Add a reconciler unit test to verify that events are sent when the sink is configured. Drop reconciler/pipelinerun/config because it's not used. It was injected in the pipeline run controller before, but not used. We can add the store for artifact configs back in a different commit, but it wil have to be part of the shared store.
afrittoli
force-pushed
the
issues/2082-add-cloud-events-pipelinerun
branch
from
14bc469
to
7f2b781
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-integration-tests |
tekton-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Replace the pipeline run controller own config store with the
shared one used by the taskrun controller too. The pipeline run
config store is only useful to the artifact storage, however
the artifact storage loads the config by fetching the configmap
via the kube client, so it does not use the config store.
Attaching the shared config store to the controller, along with
the cloud events client, enables the pipeline run controller to
start sending cloud events for all events where we send k8s events
today (except for error ones).
Add a reconciler unit test to verify that events are sent when
the sink is configured.
Fixes #2082
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes