Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in entrypoint folder #3153

Merged
merged 1 commit into from Sep 4, 2020
Merged

Fix typo in entrypoint folder #3153

merged 1 commit into from Sep 4, 2020

Conversation

ywluogg
Copy link
Contributor

@ywluogg ywluogg commented Sep 1, 2020

Changes

Fix typo in entrypoint folder

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 1, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2020
@tekton-robot
Copy link
Collaborator

Hi @ywluogg. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 1, 2020
@imjasonh
Copy link
Member

imjasonh commented Sep 1, 2020

Hey Yawen, thanks for the fix! The change looks good, there's just a couple things we need to do before we can merge this:

  • Add a release notes section. In this case, since there are no changes to report in the release notes, I've just edited your PR description to add a release-note block.

  • Squash your commits, so that your three commits become one single commit associated with this PR. To do this from your terminal, in the branch where you're making this change, see the "Squashing Commits" section of https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

Let me know if you have any trouble and I can try to help in either case.

@imjasonh
Copy link
Member

imjasonh commented Sep 1, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2020
@imjasonh
Copy link
Member

imjasonh commented Sep 1, 2020

Oh we'll also want a more descriptive PR title than "Typo" -- your change description in the PR body ("Fix typo in entrypoint folder") would make a good PR title.

(This is actually also related to commit squashing -- when a PR includes multiple changes GitHub chooses the branch name for the PR title, which tends to be pretty non-descriptive. When there's only one squashed change, GitHub chooses that commit description for the PR title, which is usually much better)

@ywluogg ywluogg changed the title Typo Fix typo in entrypoint folder Sep 1, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 1, 2020

Thanks for the comment. Edited the commit based on them

@imjasonh
Copy link
Member

imjasonh commented Sep 1, 2020

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 1, 2020
@imjasonh
Copy link
Member

imjasonh commented Sep 1, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@popcor255
Copy link
Member

popcor255 commented Sep 1, 2020

/lgtm
/cc @chmouel

Edit: I thought this was the catalog repo. 😝 🤦

@chmouel
Copy link
Member

chmouel commented Sep 2, 2020

/lgtm

Looking Good! 🤙🏽

@chmouel
Copy link
Member

chmouel commented Sep 2, 2020

/test check-pr-has-kind-label

@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 2, 2020

I still have check-pr-has-kind-label marked as yellow but it already has a kind tag.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 3, 2020

My checks were stuck, so I tried pushing a empty commit to re-try the checks to see if it fixes it.

@chmouel
Copy link
Member

chmouel commented Sep 3, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 4, 2020

/assign @imjasonh

@imjasonh
Copy link
Member

imjasonh commented Sep 4, 2020

/approve

🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2020
@tekton-robot tekton-robot merged commit cac869c into tektoncd:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants