Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update--cluster-version flag #3165

Merged
merged 4 commits into from Sep 8, 2020
Merged

Conversation

dinagraves
Copy link
Contributor

@dinagraves dinagraves commented Sep 2, 2020

/kind documentation

1.16 isn't supported anymore. When I try to run the command it returns:

ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Master version "1.16.9-gke.6" is unsupported.

Updated to 1.16.13-gke-1

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

1.16 isn't supported anymore. When I try to run the command it returns:

`ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Master version "1.16.9-gke.6" is unsupported.`

If you remove the cluster-version flag, it uses the default, which is currently 1.18.
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 2, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 2, 2020

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2020
@tekton-robot
Copy link
Collaborator

Hi @dinagraves. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinagraves
Copy link
Contributor Author

/assign @dlorenc

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 2, 2020
@jlpettersson
Copy link
Member

Thank you for this!

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2020
@dinagraves dinagraves changed the title Remove --cluster-version flag Update--cluster-version flag Sep 2, 2020
If we use latest, we won't have to update the version regularly.
@dinagraves
Copy link
Contributor Author

Note: updated to use latest instead of specific version. This will make the documentation easier to maintain. I tried running it locally:

gcloud container clusters create foobar --zone=us-central1 --cluster-version=latest

Resulted in a cluster with version 1.16.13-gke.1

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @sbwsg @dlorenc @bobcatfish @dibyom

@tekton-robot tekton-robot requested review from bobcatfish, dibyom and a user September 8, 2020 11:50
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@imjasonh
Copy link
Member

imjasonh commented Sep 8, 2020

We should just remove gcloud-specific instructions entirely, like we've done in tektoncd/website#167 -- we can merge this and I'll followup to remove it.

edit: #3174

@imjasonh
Copy link
Member

imjasonh commented Sep 8, 2020

/lgtm
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@tekton-robot tekton-robot merged commit 3dbfe8d into tektoncd:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants