Disable keep-alive for cloud-event connections #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
afrittoli
force-pushed
the
issues/3190-cloudevent-connections
branch
from
f59af3c
to
21fcc02
Compare
afrittoli
added
the
needs-cherry-pick
afrittoli
force-pushed
the
issues/3190-cloudevent-connections
branch
from
21fcc02
to
fe229e7
Compare
imjasonh
reviewed
Sep 11, 2020
|
This seems fine for now. We were already opening new connections for each cloud event delivery. This ensures that we close those connections instead of keeping them idle. In the future, would be nice to actually reuse the connections. |
Disable keep alive forces the HTTP client to drop the connection once a response is received. This avoids building up large numbers of idle connections and it fixes the immediate issue. After this we may want to see how to ensure we can re-use connection and also set and idle-connection timeout. Fixes tektoncd#3190
afrittoli
force-pushed
the
issues/3190-cloudevent-connections
branch
from
fe229e7
to
999ad73
Compare
tekton-robot
added
size/S
|
Follow up feature: #3204 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Cherry picking into 0.16.x in #3215 |
bobcatfish
removed
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Disable keep alive forces the HTTP client to drop the connection
once a response is received. This avoids building up large numbers
of idle connections and it fixes the immediate issue.
After this we may want to see how to ensure we can re-use connection
and also set and idle-connection timeout.
Fixes #3190
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind bug