Have the timeout handler decorate log lines with "key".

[mattmoor]

Several of the methods in the timeout handler deal with specific keys, and log information about them; however, they do not decorate these log lines with the key they are acting on, so when filtering by key (e.g. logstream) they don't show up. This decorates the logger with these keys in contexts where they are available.

I am hoping this will narrow down some of the timeout_test flakes I've been hunting.

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Log statements from the timeout handler will now be decorate with the key of the resource they are acting on.

cc @bobcatfish

[mattmoor]

/retest

Helm test failed with:

error building image: Get https://index.docker.io/v2/library/golang/manifests/latest: EOF

I saw a similar flake yesterday downstream, I wonder if it's worth picking a different image 🤔 Maybe one on GCR so this test isn't predicated on the availability of two registries (since kaniko already has to be pulled from there).

[vdemeester]

/meow

[tekton-robot]

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

Log statements from the timeout handler will not be decorate with the key of the resource they are acting on.

in the release note above, did you mean "will be" instead of "will not be"? 🤔

[mattmoor]

/assign @vdemeester @imjasonh @afrittoli @bobcatfish

[mattmoor]

@jerop good catch. I often typo now as not 🤦

[jerop]

/lgtm