Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dogfooding skopeo image for e2e and examples tests #3519

Merged
merged 1 commit into from Nov 13, 2020

Conversation

barthy1
Copy link
Member

@barthy1 barthy1 commented Nov 12, 2020

Changes

Unify usage of skopeo image in the tests to the dogfooding one.
Also dogfooding skopeo image is multi-arched, so several tests are moved from skipped list for s390x.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2020
@tekton-robot tekton-robot requested review from a user and vdemeester November 12, 2020 19:29
@barthy1
Copy link
Member Author

barthy1 commented Nov 12, 2020

/retest

@barthy1 barthy1 closed this Nov 12, 2020
@barthy1 barthy1 reopened this Nov 12, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@ghost ghost removed the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 13, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 13, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Nov 13, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
/lgtm

@tekton-robot tekton-robot merged commit a121ace into tektoncd:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants