Skip to content

Commit

Permalink
Use dogfooding skopeo image for e2e and examples tests
Browse files Browse the repository at this point in the history
Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
  • Loading branch information
barthy1 authored and tekton-robot committed Nov 13, 2020
1 parent 58ced47 commit a121ace
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion examples/v1alpha1/taskruns/docker-creds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ spec:
taskSpec:
steps:
- name: test
image: quay.io/rhpipeline/skopeo:alpine
image: gcr.io/tekton-releases/dogfooding/skopeo:latest
# Test pulling a private builder container.
script: skopeo copy docker://gcr.io/build-crd-testing/secret-sauce dir:///tmp/
2 changes: 1 addition & 1 deletion examples/v1alpha1/taskruns/pull-private-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ spec:
steps:
- name: pull
# Private image is just Ubuntu
image: quay.io/rhpipeline/skopeo:alpine
image: gcr.io/tekton-releases/dogfooding/skopeo:latest
script: skopeo copy docker://gcr.io/build-crd-testing/secret-sauce dir:///tmp/
2 changes: 1 addition & 1 deletion examples/v1beta1/taskruns/docker-creds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ spec:
taskSpec:
steps:
- name: test
image: quay.io/rhpipeline/skopeo:alpine
image: gcr.io/tekton-releases/dogfooding/skopeo:latest
# Test pulling a private builder container.
script: skopeo copy docker://gcr.io/build-crd-testing/secret-sauce dir:///tmp/
2 changes: 1 addition & 1 deletion examples/v1beta1/taskruns/pull-private-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ spec:
steps:
- name: pull
# Private image is just Ubuntu
image: quay.io/rhpipeline/skopeo:alpine
image: gcr.io/tekton-releases/dogfooding/skopeo:latest
script: skopeo copy docker://gcr.io/build-crd-testing/secret-sauce dir:///tmp/
4 changes: 0 additions & 4 deletions test/multiarch_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ func initExcludedTests() sets.String {
"TestExamples/v1alpha1/taskruns/build-gcs-targz",
"TestExamples/v1beta1/taskruns/build-gcs-targz",
"TestExamples/v1alpha1/taskruns/build-push-kaniko",
"TestExamples/v1alpha1/taskruns/pull-private-image",
"TestExamples/v1beta1/taskruns/pull-private-image",
"TestExamples/v1alpha1/pipelineruns/pipelinerun",
"TestExamples/v1beta1/pipelineruns/pipelinerun",
"TestExamples/v1beta1/taskruns/build-gcs-zip",
Expand All @@ -123,8 +121,6 @@ func initExcludedTests() sets.String {
//e2e
"TestHelmDeployPipelineRun",
"TestKanikoTaskRun",
"TestPipelineRun/service_account_propagation_and_pipeline_param",
"TestPipelineRun/pipelinerun_succeeds_with_LimitRange_minimum_in_namespace",
)
}
return sets.NewString()
Expand Down
4 changes: 2 additions & 2 deletions test/pipelinerun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func TestPipelineRun(t *testing.T) {
Steps: []v1beta1.Step{{
Container: corev1.Container{
Name: "config-docker",
Image: "quay.io/rhpipeline/skopeo:alpine",
Image: "gcr.io/tekton-releases/dogfooding/skopeo:latest",
Command: []string{"skopeo"},
Args: []string{"copy", "$(params.path)", "$(params.dest)"},
}},
Expand Down Expand Up @@ -186,7 +186,7 @@ func TestPipelineRun(t *testing.T) {
Steps: []v1beta1.Step{{
Container: corev1.Container{
Name: "config-docker",
Image: "quay.io/rhpipeline/skopeo:alpine",
Image: "gcr.io/tekton-releases/dogfooding/skopeo:latest",
Command: []string{"skopeo"},
Args: []string{"copy", "$(params.path)", "$(params.dest)"},
}},
Expand Down
2 changes: 1 addition & 1 deletion test/v1alpha1/pipelinerun_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func TestPipelineRun(t *testing.T) {
tb.TaskInputs(tb.InputsParamSpec("path", v1alpha1.ParamTypeString),
tb.InputsParamSpec("dest", v1alpha1.ParamTypeString)),
// Reference build: https://github.com/knative/build/tree/master/test/docker-basic
tb.Step("quay.io/rhpipeline/skopeo:alpine", tb.StepName("config-docker"),
tb.Step("gcr.io/tekton-releases/dogfooding/skopeo:latest", tb.StepName("config-docker"),
tb.StepCommand("skopeo"),
tb.StepArgs("copy", "$(inputs.params.path)", "$(inputs.params.dest)"),
),
Expand Down

0 comments on commit a121ace

Please sign in to comment.