Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYSTEM_NAMESPACE introduction in test README #3633

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Add SYSTEM_NAMESPACE introduction in test README #3633

merged 1 commit into from
Dec 17, 2020

Conversation

zhangtbj
Copy link
Contributor

Changes

Recently, there is a new change in the Knative test framework:
By default, the SYSTEM_NAMESPACE will be set as knative-testing:
https://github.com/knative/pkg/blob/67d950c438f17c46108761215c0c8394484edea5/system/testing/names.go#L29

So Tekton introduced this change, to set SYSTEM_NAMESPACE=tekton-pipelines during install_pipeline_crd:
https://github.com/tektoncd/pipeline/blob/master/test/e2e-common.sh#L30

But for our scenario, we deploy Tekton by ourselves and just need to run the E2E test by using go test directly:
https://github.com/tektoncd/pipeline/tree/master/test#end-to-end-tests

But if I don't run e2e-tests.sh I will miss this setting SYSTEM_NAMESPACE=tekton-pipelines which makes failure in some of E2E tests, like:
Failed to get ConfigMap feature-flags: configmaps "feature-flags" not found, because we don't have knative-testing namespace, so of course no configmaps "feature-flags" in there:
https://github.com/tektoncd/pipeline/blob/master/test/tektonbundles_test.go#L524

So I add this SYSTEM_NAMESPACE in the test README to help the person who wants to run the E2E by using go test directly.

/kind documentation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2020
@tekton-robot
Copy link
Collaborator

Hi @zhangtbj. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2020
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2020
@dibyom
Copy link
Member

dibyom commented Dec 16, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@tekton-robot tekton-robot merged commit a8415d9 into tektoncd:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants