Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin golang to avoid breakages. #3766

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Feb 17, 2021

Changes

/kind bug

Pin the version of Go to fix the Dockerfile build.

I see the following prior to this change:

        E0217 14:26:03.966047      12 aws_credentials.go:77] while getting AWS credentials NoCredentialProviders: no valid providers in chain. Deprecated.
        	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
        INFO[0000] Retrieving image manifest golang             
        INFO[0000] Retrieving image golang                      
        INFO[0000] Retrieving image manifest golang             
        INFO[0000] Retrieving image golang                      
        INFO[0001] Built cross stage deps: map[]                
        INFO[0001] Retrieving image manifest golang             
        INFO[0001] Retrieving image golang                      
        INFO[0001] Retrieving image manifest golang             
        INFO[0001] Retrieving image golang                      
        INFO[0001] Executing 0 build triggers                   
        INFO[0001] Unpacking rootfs as cmd COPY . /go/src/github.com/tektoncd/pipeline/ requires it. 
        INFO[0029] COPY . /go/src/github.com/tektoncd/pipeline/ 
        INFO[0033] Taking snapshot of files...                  
        INFO[0036] RUN go install github.com/tektoncd/pipeline/test/gohelloworld 
        INFO[0036] Taking snapshot of full filesystem...        
        INFO[0044] cmd: /bin/sh                                 
        INFO[0044] args: [-c go install github.com/tektoncd/pipeline/test/gohelloworld] 
        INFO[0044] Running: [/bin/sh -c go install github.com/tektoncd/pipeline/test/gohelloworld] 
        go install: version is required when current directory is not in a module
        	Try 'go install github.com/tektoncd/pipeline/test/gohelloworld@latest' to install the latest version
        error building image: error building stage: failed to execute command: waiting for process to exit: exit status 1

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/assign @afrittoli @vdemeester @imjasonh

The golang 1.16 release broke this Dockerfile.
@tekton-robot tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2021
@tekton-robot tekton-robot requested review from afrittoli and a user February 17, 2021 15:07
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2021
@AlanGreene
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@tekton-robot tekton-robot merged commit 6f692f7 into tektoncd:master Feb 17, 2021
@mattmoor mattmoor deleted the pin-golang branch February 18, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants