Rework the release pipeline to use workspaces #3788
Conversation
Stop using pipeline resources, use workspaces instead. This allows us to use the catalog tasks for build and test too. Add results with URLs of the published releases. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
The new pipeline nightly builds will run using workspaces instead of pipeline resources - once tektoncd/pipeline#3788 is merged. Change the trigger template to be able to run the new format of the pipeline. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
| --param=gitRevision="${TEKTON_RELEASE_GIT_SHA}" \ | ||
| --param=serviceAccountPath=release.json \ | ||
| --workspace name=release-secret,secret=release-secret \ | ||
| --workspace name=workarea,volumeClaimTemplateFile=workspace-template.yaml |
There was a problem hiding this comment.
I didn't know tkn could do this, very cool!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - name: publish-images | ||
| runAfter: [build, unit-tests] |
There was a problem hiding this comment.
This is interesting, executing publish-image after build and unit-test are done and in parallel with build-base-image. publish-image is not dependent on build-base-image through resources as well (or am I missing it? 😜 ). Wondering how did this work until now?
|
/lgtm Thanks @afrittoli Excited and a little nervous to release |
Heh, it's now the same pipeline for nightly and full releases, so it will be tested quite a few times before it gets to v0.22 :) |
The new pipeline nightly builds will run using workspaces instead of pipeline resources - once tektoncd/pipeline#3788 is merged. Change the trigger template to be able to run the new format of the pipeline. Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Changes
Stop using pipeline resources, use workspaces instead. This allows
us to use the catalog tasks for build and test too.
Add results with URLs of the published releases.
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes