Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update self, community and plumbing reference to use main… 🧙 #3821

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 10, 2021

Changes

… instead of master.

Signed-off-by: Vincent Demeester vincent@sbr.pm

/kind misc
/hold
/cc @afrittoli @bobcatfish @imjasonh
/cc @tektoncd/core-maintainers @tektoncd/core-collaborators

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

… instead of master.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2021
@vdemeester vdemeester changed the title Update self reference to use main… 🧙 Update self, community and plumbing reference to use main… 🧙 Mar 10, 2021
… instead of master.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2021
@pritidesai
Copy link
Member

thank you @vdemeester for holding this until 0.22 was out 🙏

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
Base automatically changed from master to main March 11, 2021 15:29
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
… instead of master.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@pritidesai
Copy link
Member

/lgtm

thank you @vdemeester 🤞

… instead of master.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@vdemeester
Copy link
Member Author

/retest

1 similar comment
@vdemeester
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit 75fc93a into tektoncd:main Mar 12, 2021
@vdemeester vdemeester deleted the rename-to-main branch March 12, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants