Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change image refs: distroless.dev -> cgr.dev/chainguard #5542

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Change image refs: distroless.dev -> cgr.dev/chainguard #5542

merged 1 commit into from
Sep 23, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Sep 22, 2022 •
edited
Loading

These images are equivalent, and both redirect to exactly the same backend location, but we're trying to move away from the distroless "brand" in favor of the "Chainguard Images" brand.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Images are based on cgr.dev/chainguard/* instead of the exactly equivalent distroless.dev/* image references.

edit: I will never not forget to remove the in the release-note block 🤬

@imjasonh
Change image refs: distroless.dev -> cgr.dev/chainguard
4ba3fc9 
These images are equivalent, and both redirect to exactly the same
backend location, but we're trying to move away from the distroless
"brand" in favor of the "Chainguard Images" brand.
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2022
@imjasonh imjasonh mentioned this pull request Sep 22, 2022
Closed
@afrittoli
Copy link
Member

/cc @skaegi

@imjasonh
Copy link
Member Author

/cc @skaegi

I should have cc'ed him myself. I mentioned some more detail in #5507

@imjasonh
Copy link
Member Author

/test tekton-pipeline-unit-tests

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2022
skaegi
skaegi approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@skaegi skaegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good technically -- we recognize the apko flavour of distroless now so a name change doesn't affect us. Was distroless.dev really just chainguard? I kind of feel like this is a bit weird that we're suddenly using the "Chainguard Images" brand but not terribly fussed about it.

@vdemeester
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@imjasonh
Copy link
Member Author

All good technically -- we recognize the apko flavour of distroless now so a name change doesn't affect us. Was distroless.dev really just chainguard? I kind of feel like this is a bit weird that we're suddenly using the "Chainguard Images" brand but not terribly fussed about it.

Yeah, it was all us all along. Sorry that wasn't well communicated, I actually think the cgr.dev name is clearer about what it is, which is part of the point.

Anyway, glad it's not a problem.

@bendory
Copy link
Contributor

bendory commented Sep 22, 2022 •
edited
Loading

Yeah, it was all us all along. Sorry that wasn't well communicated, I actually think the cgr.dev name is clearer about what it is, which is part of the point.

Does Chainguard plan to donate the distroless images to one of the various OSS foundations? I suspect that "distroless" was at least perceived as vendor-neutral (though apparently in fact it wasn't).

@imjasonh
Copy link
Member Author

Does Chainguard plan to donate the distroless images to one of the various OSS foundations? I suspect that "distroless" was at least perceived as vendor-neutral (though apparently in fact it wasn't).

We have no donation plans at this time.

IMO reusing the "distroless" name was a source of confusion. Mainly with regards to Google's OG bazel-based distroless, but increasingly the term has been used as a generic adjective by other projects, and it seemed better not to try to claim to be "the distroless" if it's becoming a generic adjective.

That being said, to avoid breaking users who adopted distroless.dev while that was the preferred name (like previous Tekton and ko releases), we'll keep the URL working indefinitely, pointed to same place as cgr.dev/chainguard/*. So if you'd prefer not to change the image ref here that's fine too.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

The images that we use today are maintained by chainguard, this change makes that more explicit, so it's +1 from me.
As far as I can see, the images are maintained by chainguard alone. Nonetheless, they are open source and Apache 2 licensed, so I have no problem with that.

afrittoli
afrittoli reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, skaegi, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlynch
Copy link
Member

wlynch commented Sep 23, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2022
@abayer
Copy link
Contributor

abayer commented Sep 23, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

check-pr-has-kind-label is green now 🎉

@tekton-robot tekton-robot merged commit 898baef into tektoncd:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@skaegi skaegi skaegi approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@abayer abayer Awaiting requested review from abayer

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@imjasonh @afrittoli @vdemeester @bendory @tekton-robot @wlynch @abayer @skaegi