Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled the whitespace linter. #5889

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Enabled the whitespace linter. #5889

merged 1 commit into from
Dec 20, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Dec 19, 2022 •
edited

Changes

There are no expected functional changes in this PR; changes to .go files should be whitespace only.

I used an ex script to cleanup white issues that the linter identified:

ex - $FILENAME <<EOF
%s/\n\n}/\r}/g
%s/\n\n\t}/\r\t}/g
%s/\n\n\t\t}/\r\t\t}/g
%s/\n\n\t\t\t}/\r\t\t\t}/g
%s/\n\n\t\t\t\t}/\r\t\t\t\t}/g
%s/{\n\n/{\r/g
%s/}\n\n}/}\r}/g
%s/}\n\n\t}/}\r\t}/g
%s/}\n\n\t\t}/}\r\t\t}/g
%s/}\n\n\t\t\t}/}\r\t\t\t}/g
%s/)\n\n\t}/)\r\t}/g
%s/)\n\n}/)\r}/g
wq
EOF

/kind cleanup
/hold

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 19, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2022
@bendory
Copy link
Contributor Author

bendory commented Dec 19, 2022

/assign jeromeju
Here's the follow-on you mentioned in #5881

@tekton-robot
Copy link
Collaborator

@bendory: GitHub didn't allow me to assign the following users: jeromeju.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign jeromeju
Here's the follow-on you mentioned in #5881

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2022
@bendory
Enabled the whitespace linter.
955fcc5 
There are no expected functional changes in this PR.

I used an `ex` script to cleanup white issues that the linter
identified:

```
ex - $FILENAME <<EOF
%s/\n\n}/\r}/g
%s/\n\n\t}/\r\t}/g
%s/\n\n\t\t}/\r\t\t}/g
%s/\n\n\t\t\t}/\r\t\t\t}/g
%s/\n\n\t\t\t\t}/\r\t\t\t\t}/g
%s/{\n\n/{\r/g
%s/}\n\n}/}\r}/g
%s/}\n\n\t}/}\r\t}/g
%s/}\n\n\t\t}/}\r\t\t}/g
%s/}\n\n\t\t\t}/}\r\t\t\t}/g
%s/)\n\n\t}/)\r\t}/g
%s/)\n\n}/)\r}/g
wq
EOF
```

/kind cleanup
/hold
@bendory
Copy link
Contributor Author

bendory commented Dec 19, 2022

/retest-required
/unhold

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2022
chuangw6
chuangw6 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@chuangw6 chuangw6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bendory !

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@bendory
Copy link
Contributor Author

bendory commented Dec 20, 2022

/assign @jerop

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuangw6, lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@tekton-robot tekton-robot merged commit e96d82e into tektoncd:main Dec 20, 2022
@bendory bendory mentioned this pull request Dec 20, 2022
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@chuangw6 chuangw6 chuangw6 approved these changes

@abayer abayer Awaiting requested review from abayer

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@jerop jerop

@chuangw6 chuangw6

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bendory @tekton-robot @lbernick @chuangw6 @jerop