Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix taskrun failing with duplicate unique image found #6260

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix taskrun failing with duplicate unique image found #6260

merged 1 commit into from
Apr 4, 2023

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Mar 1, 2023 •
edited
Loading

Changes

fix issue-6257

ignore unknown OS/architecture image entrypoint, because runtime.GOOS and runtime.GOARCH will not be unkonwn. all possible GOOS values are defined in src/go/build/syslist.go

Signed-off-by: chengjoey zchengjoey@gmail.com

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 1, 2023
@chengjoey
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Mar 1, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 74.2% -0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 74.2% -0.8

vdemeester
vdemeester approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengjoey we may want some unit tests to exercise that 👼🏼
cc @afrittoli @imjasonh

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@imjasonh imjasonh mentioned this pull request Mar 9, 2023
Merged
2 tasks
@chengjoey chengjoey force-pushed the fix/taskrun-failed-with-image branch from 947f404 to cb27814 Compare March 10, 2023 01:45
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2023
@chengjoey chengjoey force-pushed the fix/taskrun-failed-with-image branch from cb27814 to a0e8890 Compare March 10, 2023 01:47
@chengjoey
Copy link
Member Author

@chengjoey we may want some unit tests to exercise that 👼🏼 cc @afrittoli @imjasonh

thanks @vdemeester , i added unknown platform test case for buildCommandMap

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 75.8% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 75.8% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 75.8% 0.8

@chitrangpatel
Copy link
Member

/assign

@XinruZhang
Copy link
Member

/assign

@QuanZhang-William
Copy link
Member

/assign

EmmaMunley
EmmaMunley suggested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@EmmaMunley EmmaMunley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chengjoey Thank you for fixing this issue! Just a few comments/clarifications on my end. Also, can you please update the commit message and PR description adding some context on why this change is needed and why having the runtime.GOOS and runtime.GOARCH not being known was causing a failure.

cc: @jerop

pkg/pod/entrypoint_lookup_impl_test.go Outdated Show resolved Hide resolved
pkg/pod/entrypoint_lookup_impl.go Show resolved Hide resolved
pkg/pod/entrypoint_lookup_impl_test.go Show resolved Hide resolved
@chengjoey
fix taskrun failing with duplicate unique image found
f7b0647 
fix [issue-6257](tektoncd#6257)

ignore unknown OS/architecture image entrypoint, because runtime.GOOS and runtime.GOARCH will not be unkonwn.
all possible GOOS values are defined in src/go/build/syslist.go

Signed-off-by: chengjoey <zchengjoey@gmail.com>
@chengjoey chengjoey force-pushed the fix/taskrun-failed-with-image branch from a0e8890 to f7b0647 Compare March 31, 2023 03:08
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 75.8% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/entrypoint_lookup_impl.go 75.0% 75.8% 0.8

EmmaMunley
EmmaMunley approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@EmmaMunley EmmaMunley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks @chengjoey!

@TheiLLeniumStudios
Copy link

@EmmaMunley Can we please get this merged? I believe only the lgtm label is required to make it mergeable. We currently have to build custom images without provenance to handle multi-arch container images. Would really appreciate if this can get into the next release

@chengjoey
Copy link
Member Author

@EmmaMunley Can we please get this merged? I believe only the lgtm label is required to make it mergeable. We currently have to build custom images without provenance to handle multi-arch container images. Would really appreciate if this can get into the next release

@lbernick @jerop is it possible to add the lgtm to this pr

jerop
jerop approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you @chengjoey

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmmaMunley, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 80b80c6 into tektoncd:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh left review comments

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@EmmaMunley EmmaMunley EmmaMunley approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@chitrangpatel chitrangpatel

@jerop jerop

@QuanZhang-William QuanZhang-William

@XinruZhang XinruZhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TaskRun failing with duplicate unique image found
10 participants
@chengjoey @tekton-robot @chitrangpatel @XinruZhang @QuanZhang-William @TheiLLeniumStudios @vdemeester @imjasonh @jerop @EmmaMunley