Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore unknown/unknown platform in cmd/combine #1381

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Mar 9, 2023

To avoid a similar future issue to tektoncd/pipeline#6260, ignore unknown/unknown which buildkit might start injecting into index manifests in the future.

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

PR friction log:

  • I forgot to set a /kind at first and CI failed; I edited the description to set /kind but the label didn't show up, and /test didn't rerun the check.
  • unit tests failed immediately, but the link goes to a Prow page that says the test has been running for 36 minutes with no link to logs that I can find. /test also didn't rerun the check.

@imjasonh
Copy link
Member Author

imjasonh commented Mar 9, 2023

/assign @vdemeester

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
@imjasonh
Copy link
Member Author

imjasonh commented Mar 9, 2023

/test check-pr-has-kind-label

@tekton-robot
Copy link
Contributor

@imjasonh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imjasonh
Copy link
Member Author

imjasonh commented Mar 9, 2023

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2023
@imjasonh
Copy link
Member Author

imjasonh commented Mar 9, 2023

/test plumbing-unit-tests

@tekton-robot
Copy link
Contributor

@imjasonh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 9, 2023
@tekton-robot tekton-robot merged commit dbb2049 into tektoncd:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants