Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @chitrangpatel as an pipelines maintainer #7181

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add @chitrangpatel as an pipelines maintainer #7181

merged 1 commit into from
Oct 10, 2023

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 6, 2023

Changes

Chitrang has been a regular contributor to pipelines contributing many features such as sidecar logs, propagated params and workspaces, as well as the ongoing work around step reusability!

Reviews: https://github.com/tektoncd/pipeline/pulls?q=is%3Apr++reviewed-by%3Achitrangpatel+-author%3Achitrangpatel

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@dibyom
Add @chitrangpatel as an pipelines maintainer
f30555c 
Chitrang has been a regular contributor to pipelines contributing many features such as sidecar logs, propagated params and workspaces, as well as the ongoing work around step reusability!

Reviews: https://github.com/tektoncd/pipeline/pulls?q=is%3Apr++reviewed-by%3Achitrangpatel+-author%3Achitrangpatel
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 6, 2023
@dibyom
Copy link
Member Author

dibyom commented Oct 6, 2023

/kind misc

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
pritidesai
pritidesai approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chitrangpatel for all the contributions and hard work, very exciting 🎉

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
Yongxuanzhang
Yongxuanzhang approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 congrats!!

@vdemeester
Copy link
Member

/approve

jerop
jerop approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@jerop: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, pritidesai, vdemeester, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Yongxuanzhang,jerop,pritidesai,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlynch
Copy link
Member

wlynch commented Oct 10, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@chitrangpatel
Copy link
Member

/test pull-tekton-pipeline-beta-integration-tests

@tekton-robot tekton-robot merged commit 6d8f8a6 into main Oct 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai approved these changes

@jerop jerop jerop approved these changes

@Yongxuanzhang Yongxuanzhang Yongxuanzhang approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@wlynch wlynch

@afrittoli afrittoli

@jerop jerop

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dibyom @vdemeester @tekton-robot @wlynch @chitrangpatel @pritidesai @jerop @Yongxuanzhang @afrittoli