Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gsutil rsync instead of cp for buckets #737

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

nader-ziada
Copy link
Member

@nader-ziada nader-ziada commented Apr 7, 2019

Changes

Fixes #646

Use gsutil rsync instead of cp for buckets to handle the case when the bucket is empty

cp has an a bug where it will fail, but rsync works fine

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Release Notes

Use gsutil rsync instead of cp for updating storage resource, handling the case where the bucket is empy and `dir` type is used.

to handle the case when the bucket is empty
cp has an a bug where it will fail, rsync works
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 7, 2019
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pivotal-nader-ziada, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@tekton-robot tekton-robot merged commit 9a6554f into tektoncd:master Apr 8, 2019
@nader-ziada nader-ziada deleted the rsync branch April 30, 2019 18:17
nikhil-thomas pushed a commit to nikhil-thomas/pipeline that referenced this pull request Sep 14, 2021
…lpha1

Add skip test patch to v1alpha1 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching empty GCS storage bucket of type dir fails
4 participants