Move to the v1beta1 Conditions implementation.

[vdemeester]

Changes

See here for more context on what's changed (no breaking changes): knative/pkg#361

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [:no_good_man:] Includes tests (if functionality changed/added)
• [:no_good_man:] Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

cc @mattmoor

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/hold

[vdemeester]

/hold cancel

[mattmoor]

One thing this includes that I don't see here is ObservedGeneration.

For mutable types, this is important to understand whether the overall Status reflects the latest Spec.

Basically, if metadata.generation == status.observedGeneration, then I can believe the conditions.

Not for this change, but probably worth an issue.

[vdemeester]

ah I see, yeah we'll need to update our usage of Condition to reflect that then 👼
(adding this to my todo 🙃 )

[mattmoor]

/lgtm

[tekton-robot]

@mattmoor: changing LGTM is restricted to assignees, and only tektoncd/pipeline repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

Thanks for keeping everything up to date @vdemeester !! 🎉

One thing that seems to be missing from the existing commit messages - and from the linked knative/pkg PR - is kind of a higher level explanation of what's going on here (i.e. what is Conditions, why did it change to v1beta1, why do we want this change, why do we have to make it - im assuming some kind of co-vendoring situation) 🙏

Anyway tho if you want to stick with what you've got now I won't be too upset, the messages do have sweet emojis ;)

/lgtm

I wasn't clear if you wanted to make that ObservedGeneration change that @mattmoor is suggesting so:

/hold

(p.s. @mattmoor any plans on moving this lib into its own repo outside of pkg? would be pretty sweeeeet)

/meow space

[tekton-robot]

@bobcatfish:

In response to this:

Thanks for keeping everything up to date @vdemeester !! 🎉

One thing that seems to be missing from the existing commit messages - and from the linked knative/pkg PR - is kind of a higher level explanation of what's going on here (i.e. what is Conditions, why did it change to v1beta1, why do we want this change, why do we have to make it - im assuming some kind of co-vendoring situation) 🙏

Anyway tho if you want to stick with what you've got now I won't be too upset, the messages do have sweet emojis ;)

/lgtm

I wasn't clear if you wanted to make that ObservedGeneration change that @mattmoor is suggesting so:

/hold

(p.s. @mattmoor any plans on moving this lib into its own repo outside of pkg? would be pretty sweeeeet)

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

Thanks for keeping everything up to date @vdemeester !! tada

One thing that seems to be missing from the existing commit messages - and from the linked knative/pkg PR - is kind of a higher level explanation of what's going on here (i.e. what is Conditions, why did it change to v1beta1, why do we want this change, why do we have to make it - im assuming some kind of co-vendoring situation) pray

Anyway tho if you want to stick with what you've got now I won't be too upset, the messages do have sweet emojis ;)

/lgtm

Lol 😂 Right, so I wasn't sure about what to include as explaination there, but it's a mix of "keeping things up-to-date" and "assuming some kind of co-vendoring situation" in the near future 💃

I wasn't clear if you wanted to make that ObservedGeneration change that @mattmoor is suggesting so:

/hold

I was gonna fix that in a follow-up but I could do it too 😅

[dlorenc]

/lgtm

[vdemeester]

/hold cancel

[vdemeester]

ahah 😓 I need to rebase…

[vdemeester]

/test pull-tekton-pipeline-integration-tests

[bobcatfish]

/lgtm

i wasn't sure if you wanted to merge this as-is or you wanted to address @mattmoor 's comment first so feel free to remove this if you want to go ahead as-is:

/hold

[vdemeester]

/hold cancel

Let's do that in follow-up 👼