add build release yaml in pipeline third-party folder #88
Conversation
- To make deployment of the build dependency easier - Allows build pipeline to control which release of build to consume
knative-prow-robot
requested review from
aaron-prindle,
bobcatfish,
imjasonh and
shashwathi
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pivotal-nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
| name: build-controller | ||
| namespace: knative-build | ||
| --- | ||
| apiVersion: apiextensions.k8s.io/v1beta1 |
There was a problem hiding this comment.
Are these copied over from somewhere? This is a naive question, but how do user install all the build crds on their clusters?
There was a problem hiding this comment.
Its copied from the build CRD release, serving has the same. You install it by running kubectl apply -f release.yaml
There was a problem hiding this comment.
if its something practiced elsewhere i am fine.
I was thinking if we can instead use a pinned version and add instructions to download from here.
https://github.com/knative/serving/releases/download/v0.1.1/release.yaml
There was a problem hiding this comment.
The third-party folder is how serving adds the build dependency
| - -logtostderr | ||
| - -stderrthreshold | ||
| - INFO | ||
| image: gcr.io/knative-releases/github.com/knative/build/cmd/webhook@sha256:4f6458cafbe29413bf5187ca560c0e68f004080f123afe32dcd2c8c6b27ed3d3 |
There was a problem hiding this comment.
How do you feel about depending on specific tag of image and then use the https://github.com/grafeas/kritis/tree/master/cmd/kritis/kubectl/plugins/resolve plugin to resolve the tag.
There was a problem hiding this comment.
not sure how this would work, but sounds cool. We can refactor to change that?
There was a problem hiding this comment.
yep, we can follow up on that later
|
Whoops just ran into this with @dlorenc ! Very handy and timely :D |
|
@bobcatfish @tejal29 are we okay with this PR, or do you want me to change something? |
|
/lgtm |
🤖 Triggering CI on branch 'release-next' after synching to upstream/master
Fixes tektoncd#88 Make TriggerBindings more reusable This is the first pass at moving static parameters out of the TriggerBinding. This implementation moves static parameters into the EventListener where the user currently specifies all of the other static information.
related to #59
Proposed changes
/cc @imjasonh @shashwathi @bobcatfish @aaron-prindle