Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded golangci-lint to 1.50.1 (latest). #1308

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Upgraded golangci-lint to 1.50.1 (latest). #1308

merged 1 commit into from
Dec 23, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Dec 22, 2022

Changes

Upgraded golangci-lint to 1.50.1 (latest).

This will make some new linters (like dupword) available; see tektoncd/pipeline#5918.

Context: tektoncd/pipeline#5899

/kind cleanup

Submitter Checklist

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 22, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 22, 2022
@bendory
Copy link
Contributor Author

bendory commented Dec 22, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Contributor

@bendory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2022
@tekton-robot tekton-robot merged commit 54ce5f9 into tektoncd:main Dec 23, 2022
tekton-robot pushed a commit that referenced this pull request Dec 28, 2022
This change will update our plumbing to include
#1308
as well as any other changes since the last upgrade.

Context: tektoncd/pipeline#5918 (comment)
Issue: tektoncd/pipeline#5899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants