Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress and webhooks tasks to v1beta1 #499

Closed
dibyom opened this issue Mar 24, 2020 · 8 comments
Closed

Update ingress and webhooks tasks to v1beta1 #499

dibyom opened this issue Mar 24, 2020 · 8 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@dibyom
Copy link
Member

dibyom commented Mar 24, 2020

Expected Behavior

docs/create-ingress.yaml and docs/create-webhook.yaml should be v1beta1 tasks.

Actual Behavior

They are v1alpha1 tasks

Additional Info

The biggest change is probably switching the params/resources from inputs.params to just params.

cc @ncskier @akihikokuroda
/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 24, 2020
@ncskier
Copy link
Member

ncskier commented Mar 24, 2020

Do we know if people are using these? Also, should they be moved to the Tekton Catalog?

@dibyom
Copy link
Member Author

dibyom commented Mar 24, 2020

Yeah moving them to the Catalog is a good idea 💯
(though I don't know if that will complicate some of our tests such as e2e-test-ingress or not)

@akihikokuroda
Copy link
Member

/assign

@akihikokuroda
Copy link
Member

akihikokuroda commented Mar 25, 2020

I'll do this in 3 steps (pullrequest):

  1. Change the create_ingress.yaml and create_webhook.yaml in the triggers/docs
  2. Create these tasks in catalog
  3. Change the triggers/docs/README.md, triggers/docs/exposing-eventlisteners.md and triggers/docs/getting-started/README.md.
    Delete the create_ingress.yaml and create_webhook.yaml in the triggers/docs.
    Change the e-2-e tests.

This was referenced Mar 25, 2020
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants