Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Triggers to use Go Modules #527

Closed
dibyom opened this issue Apr 7, 2020 · 3 comments
Closed

Migrate Triggers to use Go Modules #527

dibyom opened this issue Apr 7, 2020 · 3 comments
Assignees
@wlynch
Labels
area/dependency Issues or PRs related to dependency changes
Milestone
Triggers v0.5.0

Comments

@dibyom
Copy link
Member

dibyom commented Apr 7, 2020

Expected Behavior

Triggers uses Go modules for dependencies

Actual Behavior

Triggers is still using dep

Additional Info

Couple of PRs already open for this: #462 #180
@dibyom dibyom added the area/dependency Issues or PRs related to dependency changes label Apr 7, 2020
@dibyom dibyom added this to the Triggers v0.5.0 milestone Apr 7, 2020
@dibyom
Copy link
Member Author

dibyom commented Apr 27, 2020

Fixed by #554

@dibyom
Copy link
Member Author

dibyom commented Apr 27, 2020

/close

@tekton-robot
Copy link

@dibyom: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

savitaashture pushed a commit to savitaashture/triggers that referenced this issue Aug 24, 2021
@openshift-ci
Merge pull request tektoncd#527 from openshift/add-1_22-patch
a0fec73 
Add vendor 1.22 patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlynch wlynch

Labels
area/dependency Issues or PRs related to dependency changes
Projects
None yet
Milestone
Triggers v0.5.0
Development

No branches or pull requests
3 participants
@wlynch @dibyom @tekton-robot