Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the ClusterInterceptors page for clarity and flow #1048

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Rewrite the ClusterInterceptors page for clarity and flow #1048

merged 1 commit into from
Apr 15, 2021

Conversation

tualeron
Copy link
Contributor

Changes

Rewrites the ClusterInterceptors page for clarity and flow.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 13, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 13, 2021
@tualeron
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 13, 2021
@tualeron
Copy link
Contributor Author

/assign @dibyom

docs/clusterinterceptors.md Outdated Show resolved Hide resolved
Rewrites the `ClusterInterceptors` page for clarity and flow.
@tualeron
Copy link
Contributor Author

I created issues to keep track of the extra info we need to add to this doc in separate PRs. Since this is just an editorial rewrite, can we get LGTM + approval?

@jmcshane
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@tualeron
Copy link
Contributor Author

Thanks James. Can we get approval?

@jmcshane
Copy link
Contributor

@sergetron I'm not an owner, so I can't approve PRs. That would have to be @dibyom

@tualeron
Copy link
Contributor Author

@sergetron I'm not an owner, so I can't approve PRs. That would have to be @dibyom

I know. The approval request was directed at others assigned to the PR.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@tekton-robot tekton-robot merged commit 07bc97a into tektoncd:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants