Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and Release Cheat Sheet #1051

Merged

Conversation

nikhil-thomas
Copy link
Member

Update README.md with links to docs and example for v0.13.0 release

Update Triggers Release Cheat Sheet

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 14, 2021
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2021
Update README.md with links to docs and example for v0.13.0 release

Update Triggers Release Cheat Sheet

Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
@nikhil-thomas nikhil-thomas force-pushed the update/readme--release-cheatsheet branch from feb5b3f to 0e854be Compare April 14, 2021 14:23
@dibyom
Copy link
Member

dibyom commented Apr 14, 2021

/test pull-tekton-triggers-build-tests

tekton/release-cheat-sheet.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@jmcshane
Copy link
Contributor

jmcshane commented May 4, 2021

@nikhil-thomas could you address the two comments left by @dibyom so we can get this documentation merged this week?

@dibyom
Copy link
Member

dibyom commented May 6, 2021

/cc @jmcshane the comments should be addressed now

@tekton-robot tekton-robot requested a review from jmcshane May 6, 2021 21:15
@tekton-robot
Copy link

@dibyom: GitHub didn't allow me to request PR reviews from the following users: addressed, now, the, should, be.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jmcshane the comments should be addressed now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhil-thomas
Copy link
Member Author

@nikhil-thomas could you address the two comments left by @dibyom so we can get this documentation merged this week?

oops, i was away for 2 weeks.

Thank you @dibyom

does this pr need any additional updates.

@dibyom
Copy link
Member

dibyom commented May 7, 2021

I think we should be all set here!

@jmcshane
Copy link
Contributor

jmcshane commented May 7, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@tekton-robot tekton-robot merged commit 3292409 into tektoncd:main May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants