Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to latest version of plumbing #1064

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

jmcshane
Copy link
Contributor

Changes

The integration tests were failing due to a GKE version upgrade that happened over the weekend.
This change will force all builds to use the regular channel, which will stay on 1.18 for the time being

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

The integration tests were failing due to a GKE version upgrade that happened over the weekend.
This change will force all builds to use the regular channel, which will stay on 1.18 for the time being
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Apr 20, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 20, 2021
@jmcshane
Copy link
Contributor Author

/assign @wlynch

Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@tekton-robot tekton-robot merged commit 30b6572 into tektoncd:main Apr 20, 2021
@jmcshane jmcshane deleted the bugfix/plumbing-update branch April 20, 2021 21:05
@jmcshane
Copy link
Contributor Author

@wlynch all the existing PRs are going to need to be rebased if they need to re-run tests. is there a way to trigger this across all open PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants