refactor: move list of allowed ResourceTemplate types to its own package #1068
Conversation
tekton-robot
added
release-note
tekton-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
| ) | ||
| } | ||
|
|
||
| // IsAllowedType returns nil if the resourceTemplate has an apiVersion |
There was a problem hiding this comment.
IsAllowed implies a bool response?
There was a problem hiding this comment.
And the calls to it are really boolean checks for it being nil or not
There was a problem hiding this comment.
I would also be in favour of e.g. EnsureAllowedType or something similar. IsSomething always implies a bool response to me as well.
There was a problem hiding this comment.
Switched to EnsureAllowedType. Thanks!
This will help reduce the number of places we keep track of the list of types that Triggers can create especially as we add the v1beta1 types. Partially addresses tektoncd#494 and part of the work needed for tektoncd#1067
|
/LGTM |
Changes
This will help reduce the number of places we keep track of the list of
types that Triggers can create especially as we add the v1beta1 types.
Partially addresses #494 and part of the work needed for #1067
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes