Bump pipeline to 0.24.1 and knative pkg to 0.22 #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
savitaashture
force-pushed
the
bump-versions
branch
from
f145113
to
d61c3a7
Compare
savitaashture
force-pushed
the
bump-versions
branch
from
d61c3a7
to
f42cc5a
Compare
|
/test pull-tekton-triggers-integration-tests |
dibyom
reviewed
May 17, 2021
| @@ -115,28 +115,6 @@ func TestTriggerTemplate_Validate(t *testing.T) { | |||
| template *v1alpha1.TriggerTemplate | |||
| want *apis.FieldError | |||
| }{{ | |||
| name: "invalid objectmetadata, name with dot", | |||
There was a problem hiding this comment.
when i update dependency i see we are not getting below error
Invalid resource name: special character . must not be present
when there is a . in objectmeta name
There was a problem hiding this comment.
Found it: tektoncd/pipeline#3891
We rely on pipelines for object meta validation. And pipelines recently started allowing dots in object names.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/cc @dibyom
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes