Updates Interceptors to use Lister to access secrets #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the github interceptor to use lister to cache the secret instead of using kubeclient, to prevent interceptor's calls to the API server from being throttled. This also moves the validation of event type before the secret validation so that it reads the secret only when the event type matches. Issue: tektoncd#1084 Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
|
/cc @savitaashture @dibyom Could you please take a look if these changes looks good for GitHub Interceptor? If it does I can do similar for other interceptors :) |
|
/test pull-tekton-triggers-integration-tests |
added 3 commits
June 4, 2021 23:26
This updates the gitlab interceptor to use lister to cache the secret instead of using kubeclient, to prevent interceptor's calls to the API server from being throttled. This also moves the validation of event type before the secret validation so that it reads the secret only when the event type matches. Issue: tektoncd#1084 Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
This updates the bitbucket interceptor to use lister to cache the secret instead of using kubeclient, to prevent interceptor's calls to the API server from being throttled. This also moves the validation of event type before the secret validation so that it reads the secret only when the event type matches. Issue: tektoncd#1084 Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
This updates the cel interceptor to use lister to cache the secret instead of using kubeclient, to prevent interceptor's calls to the API server from being throttled. This also moves the validation of event type before the secret validation so that it reads the secret only when the event type matches. Issue: tektoncd#1084 Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
savitaashture
approved these changes
Jun 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all core interceptor to use lister to cache the secret
instead of using kubeclient, to prevent interceptor's calls to the API server
from being throttled.
This also moves the validation of event type before the secret validation
so that it reads the secret only when the event type matches.
Closes #1084
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes