Adds E2E tests for Examples #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
dibyom
reviewed
Jul 1, 2021
dibyom
reviewed
Jul 1, 2021
dibyom
reviewed
Jul 1, 2021
added 2 commits
July 2, 2021 12:34
This updates the example to run in default namespace. This will make it easy to run e2e test for example as other examples run in default namespace. Also moves it in a seperate dir in examples instead of examples/selector. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
This updates the example to run el in default namespace. This will make it easy to run e2e test for example as other examples run in default namespace. Also moves it in a seperate dir in examples instead of examples/selector. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
added
size/L
This adds e2e test which would apply files and validate if el is
in running state. later, we can improve by triggering the el by
a curl command and check if works fine.
Assumptions for examples:
- name of example would be the name of directory
- name of el would be ${exampleName}-listener
Signed-off-by: Shivam Mukhade smukhade@redhat.com
dibyom
approved these changes
Jul 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests will apply the yaml files from directory and and validate
eventlistener to be in running state. later, we can improve by triggering the el by
a curl command and check if works fine.
Implements part of #192
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes