Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Event Count for EventListener Metrics #1160

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jul 22, 2021

Added metrics to add count for number of events received at sink

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Added a new metrics called event_count for events received at EventListener Sink

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 22, 2021
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 22, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/metrics.go 78.6% 79.1% 0.5

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/metrics.go 78.6% 79.1% 0.5

@dibyom
Copy link
Member

dibyom commented Jul 26, 2021

Looks good!

Can we update the docs too? https://github.com/tektoncd/triggers/blob/main/docs/eventlisteners.md#configuring-metrics-for-eventlisteners

Added metrics to add count for number of events received at sink
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sink/metrics.go 78.6% 79.1% 0.5

@khrm
Copy link
Contributor Author

khrm commented Jul 27, 2021

Updated docs with new metrics, @dibyom @savitaashture

@khrm
Copy link
Contributor Author

khrm commented Jul 27, 2021

/test pull-tekton-triggers-integration-tests

@dibyom
Copy link
Member

dibyom commented Jul 27, 2021

Thank you!
/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@tekton-robot tekton-robot merged commit a23075f into tektoncd:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants