-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Redundant Status Tag from EL Metrics #1166
Conversation
@khrm This won't be a breaking change for any current users right? |
Removing the status tag from event_count and http_duration_seconds because it is always 200.
@dibyom Good catch. This might be a breaking change if a user is using status while querying in metering system. I updated this in release section. Status field is needlessly increasing the cardinality without providing any benefit. |
@khrm Yeah, so I do not think the metrics is part of the beta API guarantees so we should be ok making this change even though it might be backwards incompatible? What do you think |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes, it is written in docs that it is experimental. So this is fine. |
/lgtm |
Removing the status tag from event_count and http_duration_seconds because it is always 200.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes