Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Status Tag from EL Metrics #1166

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jul 28, 2021

Removing the status tag from event_count and http_duration_seconds because it is always 200.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Remove Redundant Status Tag from EventListener Metrics. 
Breaking Change:
Status label has been removed from metric eventlistener_http_duration_seconds_*. Please remove querying base on status label.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 28, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2021
@dibyom
Copy link
Member

dibyom commented Jul 28, 2021

@khrm This won't be a breaking change for any current users right?

Removing the status tag from event_count and
http_duration_seconds because it is always 200.
@khrm
Copy link
Contributor Author

khrm commented Jul 29, 2021

@dibyom Good catch. This might be a breaking change if a user is using status while querying in metering system. I updated this in release section. Status field is needlessly increasing the cardinality without providing any benefit.

@dibyom
Copy link
Member

dibyom commented Jul 30, 2021

@khrm Yeah, so I do not think the metrics is part of the beta API guarantees so we should be ok making this change even though it might be backwards incompatible? What do you think

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2021
@khrm
Copy link
Contributor Author

khrm commented Aug 4, 2021

Yes, it is written in docs that it is experimental. So this is fine.

@savitaashture
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@tekton-robot tekton-robot merged commit 63c2ad7 into tektoncd:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants