Adds release tasks and pipeline for triggers #122
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
tekton/README.md
Outdated
| gcloud container clusters get-credentials prow --zone us-central1-a --project tekton-releases | ||
| ``` | ||
|
|
||
| 6. Run the `release-pipeline` (assuming you are using the production cluster and |
There was a problem hiding this comment.
The numbering here is off as well as in the Tekton repo. I made a small PR: tektoncd/pipeline#1321. Could we get this merged and then use this here?
There was a problem hiding this comment.
Still see the numbering issue in this file. The 4th point needs to be intended more due to the code fence I believe.
There was a problem hiding this comment.
yeah...should be fixed now
| @@ -0,0 +1,37 @@ | |||
| apiVersion: tekton.dev/v1alpha1 | |||
There was a problem hiding this comment.
What is this file used for? Isn't the release Task used within the release Pipeline?
There was a problem hiding this comment.
For one off testing of the publish task. Not super necessary but it makes it really quick to iterate on the publish task itself since you are not running the entire pipeline with unit tests and all!
There was a problem hiding this comment.
(I'm leaving it in there though I'm not opposed to taking it out as well 🤷♂️ )
The release tasks and pipeline are based on the pipeline project's release pipeline. The generated `release.yaml` file is published at `gcr.io/tekton-releases/triggers/latest.release.yaml`. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
/lgtm |
Changes
The release tasks and pipeline are based on the pipeline
project's release pipeline. The generated
release.yamlfileis published at
gcr.io/tekton-releases/triggers/latest.release.yaml.The release tasks for triggers and pipelines are similar enough that we
could consider using a single one in the future.
Fixes #115
cc @bobcatfish @vdemeester
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them: