Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds field labels-exclusion-pattern in feature-flag to exclude labels #1227

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Adds field labels-exclusion-pattern in feature-flag to exclude labels #1227

merged 1 commit into from
Sep 24, 2021

Conversation

sm43
Copy link
Member

@sm43 sm43 commented Sep 15, 2021 •
edited by dibyom
Loading

This adds a new field in feature-flag labels-exclusion-pattern
which by default is empty and takes regex pattern as input. If
defined this would filter out labels from propagating from el to
resources created for it such as the deployment.

Closes #1147

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

`feature-flag-triggers` configmap has a new field `labels-exclusion-pattern`, Users can now set this field with regex pattern which and controller would filter out labels matching the regex pattern from propagating from eventlistener to resources created for it such as the deployment.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 15, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 91.3% -8.7
pkg/apis/config/store.go 94.1% 95.0% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 91.3% -8.7
pkg/apis/config/store.go 94.1% 95.0% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 91.3% -8.7
pkg/apis/config/store.go 94.1% 95.0% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 91.3% -8.7
pkg/apis/config/store.go 94.1% 95.0% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 91.3% -8.7
pkg/apis/config/store.go 94.1% 95.0% 0.9

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 100.0% 90.9% -9.1
pkg/apis/config/store.go 94.1% 95.0% 0.9

dibyom
dibyom reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sm43 Code looks good. Just a few small things:

  1. Could we add a test with an invalid regex pattern for this line return "", fmt.Errorf("invalid value for feature flag %q: %q", labelsExclusionPattern, pattern)

  2. Let's document this in the docs/

  3. Add a release notes section to this PR since this is a new feature.

config/config-feature-flags.yaml Outdated Show resolved Hide resolved
config/config-feature-flags.yaml Outdated Show resolved Hide resolved
pkg/apis/config/feature_flags.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/custom_test.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/custom_test.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/deployment_test.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/deployment_test.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/meta_test.go Outdated Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/meta_test.go Show resolved Hide resolved
pkg/reconciler/eventlistener/resources/service_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/store.go 94.1% 95.0% 0.9

@sm43
Copy link
Member Author

sm43 commented Sep 24, 2021

@dibyom Thanks for the review. I have addressed the comments. Please take a look :)

@sm43 sm43 requested a review from dibyom September 24, 2021 12:23
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/store.go 94.1% 95.0% 0.9

dibyom
dibyom reviewed Sep 24, 2021
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
@dibyom
Copy link
Member

dibyom commented Sep 24, 2021

One little thing otherwise LGTM!

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
Adds field labels-exclusion-pattern in feature-flag to exclude labels
e7eb812 
This adds a new field in feature-flag `labels-exclusion-pattern`
which by default is empty and takes regex pattern as input. If
defined this would filter out labels from propagating from el to
resources created for it such as deployment, service.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 requested a review from dibyom September 24, 2021 16:14
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/store.go 94.1% 95.0% 0.9

@dibyom
Copy link
Member

dibyom commented Sep 24, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@tekton-robot tekton-robot merged commit 3b028b7 into tektoncd:main Sep 24, 2021
@sm43 sm43 deleted the exclude-label-pattern branch September 25, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@khrm khrm Awaiting requested review from khrm

@wlynch wlynch Awaiting requested review from wlynch

@savitaashture savitaashture Awaiting requested review from savitaashture

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude some labels by mask from deployment of EventListener
5 participants
@sm43 @tekton-robot @dibyom @savitaashture @vaikas