Add e2e test to verify knative examples #1250

savitaashture · 2021-10-25T16:45:42Z

Changes

Fixes #1089
PR adds changes to install Knative Serving and runs custom-resource examples for both v1alpha1 and v1beta1

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

Triggers now verify Knative based tests

savitaashture · 2021-10-26T05:42:36Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-10-26T06:12:43Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-10-26T07:56:26Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-10-26T12:22:07Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-10-26T14:16:43Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-10-26T15:13:38Z

test/e2e-test-knative-examples.sh

+  kubectl apply -f https://github.com/knative/serving/releases/download/v0.26.0/serving-crds.yaml
+  kubectl apply -f https://github.com/knative/serving/releases/download/v0.26.0/serving-core.yaml
+
+  kubectl apply -f https://github.com/knative/net-kourier/releases/download/v0.26.0/kourier.yaml
+
+  kubectl patch configmap/config-network \
+    --namespace knative-serving \
+    --type merge \
+    --patch '{"data":{"ingress.class":"kourier.ingress.networking.knative.dev"}}'
+
+  # To configure Magic DNS to access Knative Service.
+  kubectl apply -f https://github.com/knative/serving/releases/download/v0.26.0/serving-default-domain.yaml
+
+  # Wait for pods to be running in the namespaces we are deploying to
+  wait_until_pods_running knative-serving || fail_test "Knative Serving did not come up"
+  # Wait for jobs to be completed in the namespaces we are deploying to
+  wait_until_batch_job_complete knative-serving || fail_test "Knative Serving jobs did not completed"


@mattmoor I m installing Knative Serving following installation doc and i see one issue that default-domain job is not going to completed state am i doing something wrong here 🤔

Tried samething on GCP cluster locally and it worked (default-domain job went to completed state).

Any pointers would be grateful 🙏

Depends on the system you are using. For instance on KinD you need metallb for this stuff to work.

Can you share more about how it is failing?

CI is failing with below error

++ kubectl get jobs -n knative-serving --no-headers '-ocustom-columns=n:{.metadata.name},c:{.spec.completions},s:{.status.succeeded}' + local 'jobs=default-domain 1 <none>' ++ echo 'default-domain 1 <none>' ++ awk '{if ($2!=$3) print $0}' ++ wc -l + local not_complete=1 + [[ 1 -eq 0 ]] + echo -n . .+ sleep 2 + echo -e '\n\nERROR: timeout waiting for jobs to complete\ndefault-domain 1 <none>' ERROR: timeout waiting for jobs to complete default-domain 1 <none> + return 1 + fail_test 'Knative Serving jobs did not completed'

because i am using below function to wait until jobs are completed

wait_until_batch_job_complete knative-serving || fail_test "Knative Serving jobs did not completed"

Now i have doubt that does our CI cluster will have loadbalancer attached 🤔
/cc @dibyom

when i install on mu local GKE cluster where loadbalancer is attached the default-domain pod goes to completed state by using the public ip

Logs:

kubectl logs -f default-domain-nq8lk -n knative-serving W1027 06:07:37.953764 1 client_config.go:615] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work. {"level":"info","ts":1635314868.1755047,"logger":"fallback.default-domain","caller":"default-domain/main.go:225","msg":"Updated default domain to: 34.66.182.202.sslip.io"}

savitaashture · 2021-10-28T10:58:29Z

@dibyom @wlynch i have updated PR and its ready to review please do take a look at it
Thank you

savitaashture · 2021-11-02T13:36:44Z

Hi @dibyom could you take a look at this PR please

dibyom

Thanks @savitaashture Looks good overall. My main comment is can we this logic into e2e-test-examples.sh itself instead of creating a new file and copying stuff over? i.e. we can add in a couple of new functions in that file itself (curl_knative_service, install_knative_serving) and then add a new function called run_knative_tests that is basically the main from this file?

dibyom · 2021-11-02T19:46:18Z

test/e2e-test-knative-examples.sh

+  curl -v \
+   -H 'X-GitHub-Event: pull_request' \
+   -H 'X-Hub-Signature: sha1=ba0cdc263b3492a74b601d240c27efe81c4720cb' \
+   -H 'Content-Type: application/json' \


Can we put this in a curl.sh file like we do for other examples.

savitaashture · 2021-11-13T11:28:53Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-11-13T11:47:53Z

/test pull-tekton-triggers-integration-tests

savitaashture · 2021-11-15T06:01:11Z

@dibyom I have addressed comments PTAL

dibyom · 2021-11-16T16:32:07Z

Looks good. Thanks!

/approve
/lgtm

tekton-robot · 2021-11-16T16:32:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 25, 2021

tekton-robot requested review from dibyom and wlynch October 25, 2021 16:45

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2021

savitaashture force-pushed the e2e-knative-test branch from 3099601 to be5b6e8 Compare October 26, 2021 07:37

savitaashture changed the title ~~Add e2e test to verify knative examples~~ [WIP] Add e2e test to verify knative examples Oct 26, 2021

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2021

savitaashture force-pushed the e2e-knative-test branch 4 times, most recently from 0878a6c to b706ade Compare October 26, 2021 11:50

savitaashture force-pushed the e2e-knative-test branch from b706ade to 24740e0 Compare October 26, 2021 14:51

savitaashture commented Oct 26, 2021

View reviewed changes

savitaashture force-pushed the e2e-knative-test branch 2 times, most recently from 47bbdd0 to 007767a Compare October 28, 2021 09:12

savitaashture changed the title ~~[WIP] Add e2e test to verify knative examples~~ Add e2e test to verify knative examples Oct 28, 2021

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021

savitaashture force-pushed the e2e-knative-test branch 2 times, most recently from acffc83 to cd4694e Compare October 28, 2021 12:13

dibyom reviewed Nov 2, 2021

View reviewed changes

savitaashture force-pushed the e2e-knative-test branch from cd4694e to e8d6d6b Compare November 13, 2021 11:10

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2021

Add e2e test to verify knative examples

66937aa

savitaashture force-pushed the e2e-knative-test branch from e8d6d6b to 66937aa Compare November 13, 2021 11:13

tekton-robot assigned dibyom Nov 16, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021

tekton-robot merged commit a488bf7 into tektoncd:main Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e test to verify knative examples #1250

Add e2e test to verify knative examples #1250

savitaashture commented Oct 25, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture Oct 26, 2021 •

edited

Loading

mattmoor Oct 26, 2021

savitaashture Oct 27, 2021 •

edited

Loading

savitaashture Oct 27, 2021 •

edited

Loading

savitaashture commented Oct 28, 2021

savitaashture commented Nov 2, 2021

dibyom left a comment

dibyom Nov 2, 2021

savitaashture commented Nov 13, 2021

savitaashture commented Nov 13, 2021

savitaashture commented Nov 15, 2021

dibyom commented Nov 16, 2021

tekton-robot commented Nov 16, 2021

Add e2e test to verify knative examples #1250

Add e2e test to verify knative examples #1250

Conversation

savitaashture commented Oct 25, 2021

Changes

Submitter Checklist

Release Notes

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture commented Oct 26, 2021

savitaashture Oct 26, 2021 • edited Loading

Choose a reason for hiding this comment

mattmoor Oct 26, 2021

Choose a reason for hiding this comment

savitaashture Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

savitaashture Oct 27, 2021 • edited Loading

Choose a reason for hiding this comment

savitaashture commented Oct 28, 2021

savitaashture commented Nov 2, 2021

dibyom left a comment

Choose a reason for hiding this comment

dibyom Nov 2, 2021

Choose a reason for hiding this comment

savitaashture commented Nov 13, 2021

savitaashture commented Nov 13, 2021

savitaashture commented Nov 15, 2021

dibyom commented Nov 16, 2021

tekton-robot commented Nov 16, 2021

savitaashture Oct 26, 2021 •

edited

Loading

savitaashture Oct 27, 2021 •

edited

Loading

savitaashture Oct 27, 2021 •

edited

Loading